[PATCH] 126 Added package checking for pkispawn and pkidestroy.
The pkiparser.py has been modified such that it will check whether the package for the subsystem being created/removed by pkispawn/ pkidestroy has been installed. Ticket #332 -- Endi S. Dewata
ack On Fri, 2012-09-28 at 00:39 -0500, Endi Sukma Dewata wrote:
The pkiparser.py has been modified such that it will check whether the package for the subsystem being created/removed by pkispawn/ pkidestroy has been installed.
Ticket #332
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
actually .. its ok to check for the package pki-ca etc. when you want to pkispawn an instance. But maybe, we do not want to do this check when executing pkidestroy. After all someone might remove the rpm. and then try to clean up the instances. As far as I know, there isn't any reason for them not to be able to do that. Ade On Fri, 2012-09-28 at 10:02 -0400, Ade Lee wrote:
ack
On Fri, 2012-09-28 at 00:39 -0500, Endi Sukma Dewata wrote:
The pkiparser.py has been modified such that it will check whether the package for the subsystem being created/removed by pkispawn/ pkidestroy has been installed.
Ticket #332
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 9/28/2012 9:08 AM, Ade Lee wrote:
actually .. its ok to check for the package pki-ca etc. when you want to pkispawn an instance. But maybe, we do not want to do this check when executing pkidestroy.
After all someone might remove the rpm. and then try to clean up the instances. As far as I know, there isn't any reason for them not to be able to do that.
Ade
New patch attached. As discussed, we might move some deployment files into the subsystem package in the future so pkidestroy may require the subsystem package to be installed. But for now I've moved the code from pkiparse.py into pkispawn so the checking is done in pkispawn only. -- Endi S. Dewata
ACK On Sat, 2012-09-29 at 09:43 -0500, Endi Sukma Dewata wrote:
On 9/28/2012 9:08 AM, Ade Lee wrote:
actually .. its ok to check for the package pki-ca etc. when you want to pkispawn an instance. But maybe, we do not want to do this check when executing pkidestroy.
After all someone might remove the rpm. and then try to clean up the instances. As far as I know, there isn't any reason for them not to be able to do that.
Ade
New patch attached. As discussed, we might move some deployment files into the subsystem package in the future so pkidestroy may require the subsystem package to be installed. But for now I've moved the code from pkiparse.py into pkispawn so the checking is done in pkispawn only.
participants (2)
-
Ade Lee -
Endi Sukma Dewata