[PATCH] 0067 Remove vestiges of NISAuth plugin
Attached patch fixes https://fedorahosted.org/pki/ticket/1674 (NISAuth Authentication plugin , which is not present, still in the CS.cfg). Thanks, Fraser
On 1/11/2016 7:31 PM, Fraser Tweedale wrote:
Attached patch fixes https://fedorahosted.org/pki/ticket/1674 (NISAuth Authentication plugin , which is not present, still in the CS.cfg).
Thanks, Fraser
The patch removes PortalEnroll from base/ocsp/shared/conf/CS.cfg.in, is this right? The PortalEnroll is not removed from other CS.cfg.in files. Another thing, we should have an upgrade script to remove the NISAuth from the CS.cfg files in existing instances. This can be added in a separate patch. Everything else looks fine, so I'd ACK this, but I'm not familiar with NISAuth, so probably somebody else should have a look too. -- Endi S. Dewata
On Thu, Feb 11, 2016 at 09:00:50PM -0600, Endi Sukma Dewata wrote:
On 1/11/2016 7:31 PM, Fraser Tweedale wrote:
Attached patch fixes https://fedorahosted.org/pki/ticket/1674 (NISAuth Authentication plugin , which is not present, still in the CS.cfg).
Thanks, Fraser
The patch removes PortalEnroll from base/ocsp/shared/conf/CS.cfg.in, is this right? The PortalEnroll is not removed from other CS.cfg.in files.
Good catch, it was a mistake.
Another thing, we should have an upgrade script to remove the NISAuth from the CS.cfg files in existing instances. This can be added in a separate patch.
I'll file a ticket.
Everything else looks fine, so I'd ACK this, but I'm not familiar with NISAuth, so probably somebody else should have a look too.
Thanks, pushed to master (66d76bbeaf096bac3d14b1a633e1d99be57040ee) (Erroneous removal of PortalEnroll from OCSP CS.cfg was reverted). Cheers, Fraser
participants (2)
-
Endi Sukma Dewata -
Fraser Tweedale