patches for pycharm cleanup and security domain python client api
This is mostly the same patches that were reviewed before with fixes for the issues identified. I ended up making these changes over Abhishek's first cert patch, so please apply that first when reviewing. This patch is: 05e9fa7 Implemented CertResource methods in CertClient. Please review, Ade
ACK on all patches. In patch 216 - i think the debug log should be "DonePanel display: successfully added the user" "DonePanel display: successfully added the user certificate" --Abhishek On Tue, 2014-05-27 at 17:08 -0400, Ade Lee wrote:
This is mostly the same patches that were reviewed before with fixes for the issues identified. I ended up making these changes over Abhishek's first cert patch, so please apply that first when reviewing.
This patch is: 05e9fa7 Implemented CertResource methods in CertClient.
Please review, Ade _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Sorry for the spam. i made a mistake on the comment. ACK on all patches. --Abhishek On Thu, 2014-05-29 at 00:38 -0400, Abhishek Koneru wrote:
ACK on all patches.
In patch 216 - i think the debug log should be
"DonePanel display: successfully added the user" "DonePanel display: successfully added the user certificate"
--Abhishek
On Tue, 2014-05-27 at 17:08 -0400, Ade Lee wrote:
This is mostly the same patches that were reviewed before with fixes for the issues identified. I ended up making these changes over Abhishek's first cert patch, so please apply that first when reviewing.
This patch is: 05e9fa7 Implemented CertResource methods in CertClient.
Please review, Ade _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Thanks. All pushed to master. Ade On Thu, 2014-05-29 at 11:24 -0400, Abhishek Koneru wrote:
Sorry for the spam. i made a mistake on the comment.
ACK on all patches.
--Abhishek
On Thu, 2014-05-29 at 00:38 -0400, Abhishek Koneru wrote:
ACK on all patches.
In patch 216 - i think the debug log should be
"DonePanel display: successfully added the user" "DonePanel display: successfully added the user certificate"
--Abhishek
On Tue, 2014-05-27 at 17:08 -0400, Ade Lee wrote:
This is mostly the same patches that were reviewed before with fixes for the issues identified. I ended up making these changes over Abhishek's first cert patch, so please apply that first when reviewing.
This patch is: 05e9fa7 Implemented CertResource methods in CertClient.
Please review, Ade _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Abhishek Koneru -
Ade Lee