[PATCH] 170 - fix Profile Resource to send correct responses on creation/modification
First of "rules of the road" patches. Makes sure ProfileResource returns correct return code for creation/modification. Ade
On 11/5/2013 11:25 AM, Ade Lee wrote:
First of "rules of the road" patches. Makes sure ProfileResource returns correct return code for creation/modification.
Ade
ACK. There are actually some issues that need further discussion: 1. Should we use HTTP 409 (Conflict) for errors caused by entry already exists? http://stackoverflow.com/questions/3825990/http-response-code-for-post-when-... 2. If the request is OK but the server won't execute an operation (e.g. profile status doesn't allow it), should we return HTTP 403 (Forbidden)? Or maybe HTTP 422 (Unprocessable Entity)? http://stackoverflow.com/questions/3290182/rest-http-status-codes -- Endi S. Dewata
Lets go with what we have for now. We need to consider what to do in those cases based on some research into authoritative sources and maybe a look at what some other big web services (AWS, netflix, others perhaps) are doing. Returning 400 right now is OK. Ade On Wed, 2013-11-06 at 08:13 -0600, Endi Sukma Dewata wrote:
On 11/5/2013 11:25 AM, Ade Lee wrote:
First of "rules of the road" patches. Makes sure ProfileResource returns correct return code for creation/modification.
Ade
ACK.
There are actually some issues that need further discussion:
1. Should we use HTTP 409 (Conflict) for errors caused by entry already exists? http://stackoverflow.com/questions/3825990/http-response-code-for-post-when-...
2. If the request is OK but the server won't execute an operation (e.g. profile status doesn't allow it), should we return HTTP 403 (Forbidden)? Or maybe HTTP 422 (Unprocessable Entity)? http://stackoverflow.com/questions/3290182/rest-http-status-codes
oh, forgot - pushed to master. On Wed, 2013-11-06 at 08:13 -0600, Endi Sukma Dewata wrote:
On 11/5/2013 11:25 AM, Ade Lee wrote:
First of "rules of the road" patches. Makes sure ProfileResource returns correct return code for creation/modification.
Ade
ACK.
There are actually some issues that need further discussion:
1. Should we use HTTP 409 (Conflict) for errors caused by entry already exists? http://stackoverflow.com/questions/3825990/http-response-code-for-post-when-...
2. If the request is OK but the server won't execute an operation (e.g. profile status doesn't allow it), should we return HTTP 403 (Forbidden)? Or maybe HTTP 422 (Unprocessable Entity)? http://stackoverflow.com/questions/3290182/rest-http-status-codes
participants (2)
-
Ade Lee -
Endi Sukma Dewata