[PATCH] Ticket 419 - REST intrface for cert requests
On 1/18/2013 3:44 AM, Ade Lee wrote:
Please review.
The command takes a --state parameter to specify the request status. Internally we're using requestState LDAP attribute, but I think in the code and in the CLI/UI we've been using "status" quite consistently. Also, in "cert-find" the --state is used to specify the subject's state (location) instead of the certificate status. So I suggest we change the parameter and the help doc to use --status to avoid confusions. Other than that everything else is good. ACK. -- Endi S. Dewata
Thanks, change made, pushed to master. On Wed, 2013-01-23 at 02:49 +0700, Endi Sukma Dewata wrote:
On 1/18/2013 3:44 AM, Ade Lee wrote:
Please review.
The command takes a --state parameter to specify the request status. Internally we're using requestState LDAP attribute, but I think in the code and in the CLI/UI we've been using "status" quite consistently. Also, in "cert-find" the --state is used to specify the subject's state (location) instead of the certificate status. So I suggest we change the parameter and the help doc to use --status to avoid confusions.
Other than that everything else is good. ACK.
participants (2)
-
Ade Lee -
Endi Sukma Dewata