[PATCH 0044 Don't use settings like HTTP proxy from env vars
The PKIConnection class uses python-requests for HTTPS. The library picks up several settings from environment variables, e.g. HTTP proxy server, certificate bundle with trust anchors and authentication. A proxy can interfere with the Dogtag installer and cause some operations to fail. With session.trust_env = False python-requests no longer inspects the environment and Dogtag has full controll over its connection settings. https://requests.readthedocs.org/en/latest/api/?highlight=trust_env#requests... https://fedorahosted.org/pki/ticket/1733 https://fedorahosted.org/freeipa/ticket/5555
On Thu, Jan 14, 2016 at 01:34:47PM +0100, Christian Heimes wrote:
The PKIConnection class uses python-requests for HTTPS. The library picks up several settings from environment variables, e.g. HTTP proxy server, certificate bundle with trust anchors and authentication. A proxy can interfere with the Dogtag installer and cause some operations to fail.
With session.trust_env = False python-requests no longer inspects the environment and Dogtag has full controll over its connection settings.
https://requests.readthedocs.org/en/latest/api/?highlight=trust_env#requests...
https://fedorahosted.org/pki/ticket/1733 https://fedorahosted.org/freeipa/ticket/5555
Works as advertised :) ACK
On 2016-01-14 13:34, Christian Heimes wrote:
The PKIConnection class uses python-requests for HTTPS. The library picks up several settings from environment variables, e.g. HTTP proxy server, certificate bundle with trust anchors and authentication. A proxy can interfere with the Dogtag installer and cause some operations to fail.
With session.trust_env = False python-requests no longer inspects the environment and Dogtag has full controll over its connection settings.
https://requests.readthedocs.org/en/latest/api/?highlight=trust_env#requests...
https://fedorahosted.org/pki/ticket/1733 https://fedorahosted.org/freeipa/ticket/5555
Endi suggested to keep the default and only disable trust_env in the installer. Here is an updated patch. Christian
On Tue, Jan 19, 2016 at 11:26:12AM +0100, Christian Heimes wrote:
On 2016-01-14 13:34, Christian Heimes wrote:
The PKIConnection class uses python-requests for HTTPS. The library picks up several settings from environment variables, e.g. HTTP proxy server, certificate bundle with trust anchors and authentication. A proxy can interfere with the Dogtag installer and cause some operations to fail.
With session.trust_env = False python-requests no longer inspects the environment and Dogtag has full controll over its connection settings.
https://requests.readthedocs.org/en/latest/api/?highlight=trust_env#requests...
https://fedorahosted.org/pki/ticket/1733 https://fedorahosted.org/freeipa/ticket/5555
Endi suggested to keep the default and only disable trust_env in the installer. Here is an updated patch.
Christian
ACK on updated patch
On 2016-01-20 02:56, Fraser Tweedale wrote:
On Tue, Jan 19, 2016 at 11:26:12AM +0100, Christian Heimes wrote:
On 2016-01-14 13:34, Christian Heimes wrote:
The PKIConnection class uses python-requests for HTTPS. The library picks up several settings from environment variables, e.g. HTTP proxy server, certificate bundle with trust anchors and authentication. A proxy can interfere with the Dogtag installer and cause some operations to fail.
With session.trust_env = False python-requests no longer inspects the environment and Dogtag has full controll over its connection settings.
https://requests.readthedocs.org/en/latest/api/?highlight=trust_env#requests...
https://fedorahosted.org/pki/ticket/1733 https://fedorahosted.org/freeipa/ticket/5555
Endi suggested to keep the default and only disable trust_env in the installer. Here is an updated patch.
Christian
ACK on updated patch
Thanks for the reviews! Pushed to master in 387d09045fb37b71bc0f1980f16ca70bc071996c
participants (2)
-
Christian Heimes -
Fraser Tweedale