[PATCH] 190 Reorganized TPS templates and scripts.
The templates, JS, and CGI scripts for TPS have been moved into the TPS core package. Removed unused cfg.pl. Ticket #407 -- Endi S. Dewata
Looks good - and is the right idea. What makes you think that cfg.pl is not used? There are functions that are defined there that are used in the esc cgi scripts. Please restore cfg.pl. On Tue, 2012-11-27 at 16:15 -0600, Endi Sukma Dewata wrote:
The templates, JS, and CGI scripts for TPS have been moved into the TPS core package. Removed unused cfg.pl.
Ticket #407
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 11/29/2012 11:59 PM, Ade Lee wrote:
Looks good - and is the right idea. What makes you think that cfg.pl is not used? There are functions that are defined there that are used in the esc cgi scripts.
Please restore cfg.pl.
As discussed on IRC, there are 2 cfg.pl files, one in the TPS core page and the other in the TPS theme package. In the original code before the patch, the code in pkicreate:2064 copies the cfg.pl in theme to override the cfg.pl in core: return 0 if !copy_directory($ui_subsystem_path, $pki_instance_path, $default_dir_permissions, $default_file_permissions, $pki_user, $pki_group); So the original cfg.pl in core package was never actually used. In the updated #192 this code no longer exists since the TPS theme has being removed. -- Endi S. Dewata
On Sun, 2012-12-02 at 20:55 -0600, Endi Sukma Dewata wrote:
On 11/29/2012 11:59 PM, Ade Lee wrote:
Looks good - and is the right idea. What makes you think that cfg.pl is not used? There are functions that are defined there that are used in the esc cgi scripts.
Please restore cfg.pl.
As discussed on IRC, there are 2 cfg.pl files, one in the TPS core page and the other in the TPS theme package. In the original code before the patch, the code in pkicreate:2064 copies the cfg.pl in theme to override the cfg.pl in core:
return 0 if !copy_directory($ui_subsystem_path, $pki_instance_path, $default_dir_permissions, $default_file_permissions, $pki_user, $pki_group);
So the original cfg.pl in core package was never actually used.
In the updated #192 this code no longer exists since the TPS theme has being removed.
ACK. Whats troubling is that neither version appears to be correct. The correct version is in the 8.1 branch. We don't have to fix this here. You can commit your patch, but please open a ticket to fix the security officer workstation cgi scripts in dogtag 10.
On 12/3/2012 9:36 AM, Ade Lee wrote:
ACK.
Whats troubling is that neither version appears to be correct. The correct version is in the 8.1 branch. We don't have to fix this here. You can commit your patch, but please open a ticket to fix the security officer workstation cgi scripts in dogtag 10.
Pushed to master. Ticket for SOW: https://fedorahosted.org/pki/ticket/429 -- Endi S. Dewata
participants (2)
-
Ade Lee -
Endi Sukma Dewata