2:10 p.m.
Code formatting rules to be used in Eclipse for formatting once current
patches are checked in.
Ade
8:10 p.m.
On 12/01/2011 03:10 PM, Ade Lee wrote:
Code formatting rules to be used in Eclipse for formatting once
current
patches are checked in.
Ade
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
The rules look OK. The name in
my project shows up as :
Unmanaged profile 'PKI Project Profile'
Which looks like something wrapped 'PKI Project Profile' by accident
I did a dry run of formatting the project
[ayoung@ayoung pki]$ git diff | wc -l
387864
so it probably changes about 150K lines.
Can someone else confirm that they can see the project specific settings
and that the name is messed up?
11:19 p.m.
On 12/01/2011 06:10 PM, Adam Young wrote:
On 12/01/2011 03:10 PM, Ade Lee wrote:
> Code formatting rules to be used in Eclipse for formatting once current
> patches are checked in.
>
> Ade
>
The patch doesn't apply correctly for
me using 'git am', so I had to
fall back to 'git apply'. That said:
[nkinder@localhost pki]$ git diff | wc -l
387843
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
The rules look OK. The name in
my project shows up as :
Unmanaged profile 'PKI Project Profile'
Which looks like something wrapped 'PKI Project Profile' by accident
I did a dry run of formatting the project
[ayoung@ayoung pki]$ git diff | wc -l
387864
so it probably changes about 150K lines.
Can someone else confirm that they can see the project specific
settings and that the name is messed up?
I'm still new to Eclipse, so I'm
not sure where to look for the name and
settings you're referring to.
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
8:39 a.m.
Nathan,
The patch may not have applied cleanly for you because it was done
against the git svn instance -- on the assumption that we were going to
blow away the git instance. If that isn't going to happen -- and my
guess is that it will not, I will regenerate the patch on the git
instance.
Ade
On Thu, 2011-12-01 at 21:19 -0800, Nathan Kinder wrote:
On 12/01/2011 06:10 PM, Adam Young wrote:
> On 12/01/2011 03:10 PM, Ade Lee wrote:
> > Code formatting rules to be used in Eclipse for formatting once current
> > patches are checked in.
> >
> > Ade
> >
> >
> >
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
> The rules look OK. The name in my project shows up as :
> Unmanaged profile 'PKI Project Profile'
>
> Which looks like something wrapped 'PKI Project Profile' by
> accident
>
> I did a dry run of formatting the project
> [ayoung@ayoung pki]$ git diff | wc -l
> 387864
> so it probably changes about 150K lines.
The patch doesn't apply correctly for me using 'git am', so I had to
fall back to 'git apply'. That said:
[nkinder@localhost pki]$ git diff | wc -l
387843
>
> Can someone else confirm that they can see the project specific
> settings and that the name is messed up?
I'm still new to Eclipse, so I'm not sure where to look for the name
and settings you're referring to.
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
9:35 a.m.
On 12/02/2011 06:39 AM, Ade Lee wrote:
Nathan,
The patch may not have applied cleanly for you because it was done
against the git svn instance -- on the assumption that we were going to
blow away the git instance. If that isn't going to happen -- and my
guess is that it will not, I will regenerate the patch on the git
instance.
I thought that might be the case. Go ahead and generate it against the
git repo. At
this point, I see no reason to wipe out our git repo and re-import.
Ade
On Thu, 2011-12-01 at 21:19 -0800, Nathan Kinder wrote:
> On 12/01/2011 06:10 PM, Adam Young wrote:
>> On 12/01/2011 03:10 PM, Ade Lee wrote:
>>> Code formatting rules to be used in Eclipse for formatting once current
>>> patches are checked in.
>>>
>>> Ade
>>>
>>>
>>>
>>> _______________________________________________
>>> Pki-devel mailing list
>>> Pki-devel(a)redhat.com
>>> https://www.redhat.com/mailman/listinfo/pki-devel
>> The rules look OK. The name in my project shows up as :
>> Unmanaged profile 'PKI Project Profile'
>>
>> Which looks like something wrapped 'PKI Project Profile' by
>> accident
>>
>> I did a dry run of formatting the project
>> [ayoung@ayoung pki]$ git diff | wc -l
>> 387864
>> so it probably changes about 150K lines.
> The patch doesn't apply correctly for me using 'git am', so I had to
> fall back to 'git apply'. That said:
>
> [nkinder@localhost pki]$ git diff | wc -l
> 387843
>> Can someone else confirm that they can see the project specific
>> settings and that the name is messed up?
> I'm still new to Eclipse, so I'm not sure where to look for the name
> and settings you're referring to.
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel(a)redhat.com
>> https://www.redhat.com/mailman/listinfo/pki-devel
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
8:51 a.m.
On 12/02/2011 12:19 AM, Nathan Kinder wrote:
On 12/01/2011 06:10 PM, Adam Young wrote:
> On 12/01/2011 03:10 PM, Ade Lee wrote:
>> Code formatting rules to be used in Eclipse for formatting once current
>> patches are checked in.
>>
>> Ade
>>
>>
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel(a)redhat.com
>> https://www.redhat.com/mailman/listinfo/pki-devel
> The rules look OK. The name in my project shows up as :
> Unmanaged profile 'PKI Project Profile'
>
> Which looks like something wrapped 'PKI Project Profile' by accident
>
> I did a dry run of formatting the project
> [ayoung@ayoung pki]$ git diff | wc -l
> 387864
> so it probably changes about 150K lines.
The patch doesn't apply correctly for me using 'git am', so I had to
fall back to 'git apply'. That said:
Ok, this is a known problem:
Edit the patch by hand and remove the leading >. It is the email client
that adds that. After that, the patch should apply.
To get around this problem, appply this fix:
Thunderbird has a nasty habit of prepending a > character to the patch,
messing up the format. While it is trivial to edit the patch by hand to
remove it, the patch sender can help out by configuring Thunderbird this
way:
* In Thunderbird Preferences,
* Go to the Advanced->General tab.
* Select "Config Editor"
* Search for mail.file_attach_binary and
* Set this value to true
[nkinder@localhost pki]$ git diff | wc -l
387843
>
> Can someone else confirm that they can see the project specific
> settings and that the name is messed up?
I'm still new to Eclipse, so I'm not sure where to look for the name
and settings you're referring to.
Windows->Preferences->Java ->Code Style Formatter->Configure Project
Specific Settings (Link at the top right of the page)
If the patch has been applied, and you click the checkbox that says :
Show on Projects with Project Specific Settings, you should still see
the pki project. Click OK, and you should see the porofile name in a
drop down list. You can edit that by clicking "edit" to the right.
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
9:39 a.m.
On 12/01/2011 03:10 PM, Ade Lee wrote:
Code formatting rules to be used in Eclipse for formatting once
current
patches are checked in.
Ade
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
ACK.
9:40 a.m.
On 12/01/2011 03:10 PM, Ade Lee wrote:
Code formatting rules to be used in Eclipse for formatting once
current
patches are checked in.
Ade
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
Pushed to master in the git repo
4531
days inactive
4532
days old
7 comments
3 participants
participants (3)
-
Adam Young -
Ade Lee -
Nathan Kinder