[PATCH] 135 - handle case where no subsystem certs are created
Modify pkispawn to handle case where no subsystemCerts are generated When installing clone of a KRA into an existing instance, no new system certs are generated, and so the systemCerts parameter is not populated. This patch addresses this issue. Please review. Ade
Looks good. ACK. Question though. Would it make any sense to log this exception. I suppose that is what the following construct is for: except KeyError as exc: thanks, jack ----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: pki-devel@redhat.com Sent: Wednesday, June 26, 2013 1:56:52 PM Subject: [Pki-devel] [PATCH] 135 - handle case where no subsystem certs are created Modify pkispawn to handle case where no subsystemCerts are generated When installing clone of a KRA into an existing instance, no new system certs are generated, and so the systemCerts parameter is not populated. This patch addresses this issue. Please review. Ade _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Added log and pushed to master and 10.0 branch. On Wed, 2013-06-26 at 19:15 -0400, John Magne wrote:
Looks good.
ACK.
Question though.
Would it make any sense to log this exception. I suppose that is what the following construct is for:
except KeyError as exc:
thanks, jack
----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: pki-devel@redhat.com Sent: Wednesday, June 26, 2013 1:56:52 PM Subject: [Pki-devel] [PATCH] 135 - handle case where no subsystem certs are created
Modify pkispawn to handle case where no subsystemCerts are generated
When installing clone of a KRA into an existing instance, no new system certs are generated, and so the systemCerts parameter is not populated. This patch addresses this issue.
Please review.
Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Ade Lee -
John Magne