[PATCH] pki-cfu-0036-ticket-1158-CMCRequest-does-not-support-internal-tok.patch
It seems the CMCRequest java tool initializes its token to be hardcoded as "internal". In case when -h is not specified, it will attempt to do getTokenByName and will get a token not found error. I checked all the other java tools they initialize tokenname to be null, and properly calls getInternalKeyStorageToken from jss CryptoManager. This fix allows CMCRequest to now work with internal token. Please review. thanks, Christina
ACK Looks like we have feature parity with the others tools. If tested to work. Good. ----- Original Message ----- From: "Christina Fu" <cfu@redhat.com> To: pki-devel@redhat.com Sent: Friday, September 12, 2014 3:24:10 PM Subject: [Pki-devel] [PATCH] pki-cfu-0036-ticket-1158-CMCRequest-does-not-support-internal-tok.patch It seems the CMCRequest java tool initializes its token to be hardcoded as "internal". In case when -h is not specified, it will attempt to do getTokenByName and will get a token not found error. I checked all the other java tools they initialize tokenname to be null, and properly calls getInternalKeyStorageToken from jss CryptoManager. This fix allows CMCRequest to now work with internal token. Please review. thanks, Christina _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
pushed to master: commit 577af336fcb5a9943d5f183161869c729b77926b thanks, Christina On 09/16/2014 11:01 AM, John Magne wrote:
ACK
Looks like we have feature parity with the others tools.
If tested to work. Good.
----- Original Message ----- From: "Christina Fu" <cfu@redhat.com> To: pki-devel@redhat.com Sent: Friday, September 12, 2014 3:24:10 PM Subject: [Pki-devel] [PATCH] pki-cfu-0036-ticket-1158-CMCRequest-does-not-support-internal-tok.patch
It seems the CMCRequest java tool initializes its token to be hardcoded as "internal". In case when -h is not specified, it will attempt to do getTokenByName and will get a token not found error. I checked all the other java tools they initialize tokenname to be null, and properly calls getInternalKeyStorageToken from jss CryptoManager.
This fix allows CMCRequest to now work with internal token.
Please review. thanks, Christina
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Christina Fu -
John Magne