[PATCH] 61 Change how installation summary is displayed. Ticket#599 - Dogtag 10.0.3
Please review the patch which shows the installation summary, only when pki_skip_configuration is not True. Also the client database details are shown only when pki_client_database_purge=False. The configuration url is already shown when pki_skip_configuration = true. --Abhishek
Looks pretty good, but still can easily overflow on an 80 char window. Lets do something like this - that is, break up some of the lines. ========================================================================== INSTALLATION SUMMARY ========================================================================== Admin username: caadmin Client certificate nickname: PKI Administrator for laptop To check the status of the subsystem: systemctl status pki-tomcatd\@pki-tomcat34.service To restart the subsystem: systemctl restart pki-tomcatd\@pki-tomcat34.service The URL for the subsystem is https://aleeredhat.laptop:8343/ca ========================================================================== - Ade On Wed, 2013-06-05 at 14:38 -0400, Abhishek Koneru wrote:
Please review the patch which shows the installation summary, only when pki_skip_configuration is not True. Also the client database details are shown only when pki_client_database_purge=False.
The configuration url is already shown when pki_skip_configuration = true.
--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 6/5/2013 1:38 PM, Abhishek Koneru wrote:
Please review the patch which shows the installation summary, only when pki_skip_configuration is not True. Also the client database details are shown only when pki_client_database_purge=False.
The configuration url is already shown when pki_skip_configuration = true.
--Abhishek
ACK, but there are a few things that can be done separately: 1. In ticket #599, item #3 says that the configuration URL should be displayed in the installation summary if we're skipping configuration. In other words, pkispawn should always end with an installation summary. Probably something like this: ========================================================================== INSTALLATION SUMMARY ========================================================================== Please start the configuration by accessing: https://test.example.com:8443/ca/admin/console/config/login?pin=DX5SF6JLfhdn... After configuration, the server can be operated by the command: systemctl restart pki-tomcatd@ca-master.service ========================================================================== 2. Since we have installation summary, the "Installation complete" message might not be needed anymore. -- Endi S. Dewata
participants (3)
-
Abhishek Koneru -
Ade Lee -
Endi Sukma Dewata