[PATCH] 0062 Block startup until initial profile load completed
Hi all, The attached patch fixes https://fedorahosted.org/pki/ticket/1702 Cheers, Fraser
On 11/30/2015 11:57 PM, Fraser Tweedale wrote:
Hi all,
The attached patch fixes https://fedorahosted.org/pki/ticket/1702
Cheers, Fraser
ACK. Just some comments: 1. It would be nice to log the InterruptedException so we know if it happens. 2. Not a problem, but the code that reads the numSubordinates probably could be moved before the loop so it's guaranteed to be executed exactly once. -- Endi S. Dewata
On Wed, Jan 20, 2016 at 02:30:40PM -0600, Endi Sukma Dewata wrote:
On 11/30/2015 11:57 PM, Fraser Tweedale wrote:
Hi all,
The attached patch fixes https://fedorahosted.org/pki/ticket/1702
Cheers, Fraser
ACK. Just some comments:
Thanks; pushed to master (5fae5826e5442d7266681d19f282dc7728062b89). Will push to 10.2 branch shortly.
1. It would be nice to log the InterruptedException so we know if it happens.
I added a log message.
2. Not a problem, but the code that reads the numSubordinates probably could be moved before the loop so it's guaranteed to be executed exactly once.
It has to be done as part of the one search, to guarantee that no profiles are added/removed between the search to determine the number of profiles, and a subsequent search to load them. Cheers, Fraser
On Thu, Jan 21, 2016 at 11:07:14AM +1000, Fraser Tweedale wrote:
On Wed, Jan 20, 2016 at 02:30:40PM -0600, Endi Sukma Dewata wrote:
On 11/30/2015 11:57 PM, Fraser Tweedale wrote:
Hi all,
The attached patch fixes https://fedorahosted.org/pki/ticket/1702
Cheers, Fraser
ACK. Just some comments:
Thanks; pushed to master (5fae5826e5442d7266681d19f282dc7728062b89). Will push to 10.2 branch shortly.
Pushed to DOGTAG_10_2_BRANCH: * e8a1d9c Block startup until initial profile load completed
participants (2)
-
Endi Sukma Dewata -
Fraser Tweedale