[PATCH] 219-222 Fix formatting etc. in server python code
Had a bit of time on the plane and wanted to clean things up. These patches address PEP 8 issues (mostly formatting) and some others as identified by pycharm in the server code. Cuts down about a thousand errors/warnings to about 170. Please review, Ade
On 6/9/2014 10:41 AM, Ade Lee wrote:
Had a bit of time on the plane and wanted to clean things up. These patches address PEP 8 issues (mostly formatting) and some others as identified by pycharm in the server code.
Cuts down about a thousand errors/warnings to about 170.
Please review, Ade
Looks like a straight forward cleanup. Assuming this is already tested, ACK. -- Endi S. Dewata
ACK on all patches for the warnings addressed. Though a very few lines have exceed the 80 char length - i think you ignored them because they were characters notpart of a statement, like (:, \). I was able to build the rpms and install a CA. -- Abhishek ----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: pki-devel@redhat.com Sent: Monday, June 9, 2014 11:41:00 AM Subject: [Pki-devel] [PATCH] 219-222 Fix formatting etc. in server python code Had a bit of time on the plane and wanted to clean things up. These patches address PEP 8 issues (mostly formatting) and some others as identified by pycharm in the server code. Cuts down about a thousand errors/warnings to about 170. Please review, Ade _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On Tue, 2014-06-10 at 00:23 -0400, Abhishek Koneru wrote:
ACK on all patches for the warnings addressed. Though a very few lines have exceed the 80 char length - i think you ignored them because they were characters notpart of a statement, like (:, \).
I ignored those for now because I couldn't find an elegant way to cut down the line. Some of them simply have attribute names that are too long, or are part of long conditionals that are probably better encapsulated in a helper function. As I was making enough other changes, I did not want to muddy the waters. We can fix those in a later patch. Thanks for acks, Endi and Abhishek, pushed to master.
I was able to build the rpms and install a CA.
-- Abhishek
----- Original Message ----- From: "Ade Lee" <alee@redhat.com> To: pki-devel@redhat.com Sent: Monday, June 9, 2014 11:41:00 AM Subject: [Pki-devel] [PATCH] 219-222 Fix formatting etc. in server python code
Had a bit of time on the plane and wanted to clean things up. These patches address PEP 8 issues (mostly formatting) and some others as identified by pycharm in the server code.
Cuts down about a thousand errors/warnings to about 170.
Please review, Ade
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (3)
-
Abhishek Koneru -
Ade Lee -
Endi Sukma Dewata