9:23 p.m.
Please review the attached patch with fixes for trac ticket 507 which
addresses the issue of the pki.conf being replaced while upgrading pki.
--Abhishek
10:19 a.m.
1. Same comment about commit message being too long.
2. In general, when you change the spec file, you might update the
version. In this case, as there are many spec files changes coming in,
we will dispense with that.
ACK
On Fri, 2013-03-15 at 22:23 -0400, Abhishek Koneru wrote:
Please review the attached patch with fixes for trac ticket 507
which
addresses the issue of the pki.conf being replaced while upgrading pki.
--Abhishek
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
1:44 p.m.
New subject: [PATCH]39-2 A revised fix for trac ticket #507 - Making the pki.conf irreplacebale by an upgrade
Please find attached the revised fix for #507 after discussing with Ade,
Matt and Endi for review.
The final state of the pki.conf file follow the same rules as shown for
the macro %config(noreplace) here:
http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html.
Additionally, during un-install, if pki.conf is edited on the disk, then
it is saved as pki.conf.rpm.save in /etc/pki.
--Abhishek
On Tue, 2013-03-19 at 11:19 -0400, Ade Lee wrote:
1. Same comment about commit message being too long.
2. In general, when you change the spec file, you might update the
version. In this case, as there are many spec files changes coming in,
we will dispense with that.
ACK
On Fri, 2013-03-15 at 22:23 -0400, Abhishek Koneru wrote:
> Please review the attached patch with fixes for trac ticket 507 which
> addresses the issue of the pki.conf being replaced while upgrading pki.
>
> --Abhishek
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
3:51 p.m.
New subject: [PATCH]39-2 A revised fix for trac ticket #507 - Making the pki.conf irreplacebale by an upgrade
On 3/20/2013 1:44 PM, Abhishek Koneru wrote:
Please find attached the revised fix for #507 after discussing with
Ade,
Matt and Endi for review.
The final state of the pki.conf file follow the same rules as shown for
the macro %config(noreplace) here:
http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html.
Additionally, during un-install, if pki.conf is edited on the disk, then
it is saved as pki.conf.rpm.save in /etc/pki.
I think the default.cfg is not user configurable, so it shouldn't be
marked with %config.
--
Endi S. Dewata
11:47 p.m.
New subject: [PATCH]39-2 A revised fix for trac ticket #507 - Making the pki.conf irreplacebale by an upgrade
agreed. default.cfg should not be user configurable.
After removing the %config on that file - ACK.
On Wed, 2013-03-20 at 15:51 -0500, Endi Sukma Dewata wrote:
On 3/20/2013 1:44 PM, Abhishek Koneru wrote:
> Please find attached the revised fix for #507 after discussing with Ade,
> Matt and Endi for review.
> The final state of the pki.conf file follow the same rules as shown for
> the macro %config(noreplace) here:
> http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html.
>
> Additionally, during un-install, if pki.conf is edited on the disk, then
> it is saved as pki.conf.rpm.save in /etc/pki.
I think the default.cfg is not user configurable, so it shouldn't be
marked with %config.
11:43 a.m.
New subject: [PATCH]39-2 A revised fix for trac ticket #507 - Making the pki.conf irreplacebale by an upgrade
Removed the %config tag for default.cfg.
Pushed to master.
--Abhishek
----- Original Message -----
From: "Ade Lee" <alee(a)redhat.com>
To: "Endi Sukma Dewata" <edewata(a)redhat.com>
Cc: "Abhishek Koneru" <akoneru(a)redhat.com>, pki-devel(a)redhat.com
Sent: Thursday, March 21, 2013 12:47:18 AM
Subject: Re: [Pki-devel] [PATCH]39-2 A revised fix for trac ticket #507 - Making the
pki.conf irreplacebale by an upgrade
agreed. default.cfg should not be user configurable.
After removing the %config on that file - ACK.
On Wed, 2013-03-20 at 15:51 -0500, Endi Sukma Dewata wrote:
On 3/20/2013 1:44 PM, Abhishek Koneru wrote:
> Please find attached the revised fix for #507 after discussing with Ade,
> Matt and Endi for review.
> The final state of the pki.conf file follow the same rules as shown for
> the macro %config(noreplace) here:
> http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html.
>
> Additionally, during un-install, if pki.conf is edited on the disk, then
> it is saved as pki.conf.rpm.save in /etc/pki.
I think the default.cfg is not user configurable, so it shouldn't be
marked with %config.
4064
days inactive
4069
days old
5 comments
3 participants
participants (3)
-
Abhishek Koneru -
Ade Lee -
Endi Sukma Dewata