Please find attached the revised fix for #507 after discussing with Ade, Matt and Endi for review. The final state of the pki.conf file follow the same rules as shown for the macro %config(noreplace) here: http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html. Additionally, during un-install, if pki.conf is edited on the disk, then it is saved as pki.conf.rpm.save in /etc/pki. --Abhishek On Tue, 2013-03-19 at 11:19 -0400, Ade Lee wrote:

1. Same comment about commit message being too long. 2. In general, when you change the spec file, you might update the version. In this case, as there are many spec files changes coming in, we will dispense with that.

ACK

On Fri, 2013-03-15 at 22:23 -0400, Abhishek Koneru wrote:

...

Please review the attached patch with fixes for trac ticket 507 which addresses the issue of the pki.conf being replaced while upgrading pki.

--Abhishek _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel

agreed. default.cfg should not be user configurable. After removing the %config on that file - ACK. On Wed, 2013-03-20 at 15:51 -0500, Endi Sukma Dewata wrote:

On 3/20/2013 1:44 PM, Abhishek Koneru wrote:

...

Please find attached the revised fix for #507 after discussing with Ade, Matt and Endi for review. The final state of the pki.conf file follow the same rules as shown for the macro %config(noreplace) here: http://www-uxsup.csx.cam.ac.uk/~jw35/docs/rpm_config.html.

Additionally, during un-install, if pki.conf is edited on the disk, then it is saved as pki.conf.rpm.save in /etc/pki.

I think the default.cfg is not user configurable, so it shouldn't be marked with %config.