[PATCH] 55 If a configuration result has a single cert, cconvert it into an array #Ticket 593
Please review the patch with fix for issue #593. Issue: The code expects a list of system certs in a configuration result. But if there is only one cert, the JSON result has just the object but not a list with one object. Fix: Put the single cert in an array and continue. Both CA and clone CA installed fine and passed smoke test. --Abhishek
On 4/23/2013 5:23 PM, Abhishek Koneru wrote:
Please review the patch with fix for issue #593.
Issue:
The code expects a list of system certs in a configuration result. But if there is only one cert, the JSON result has just the object but not a list with one object.
Fix:
Put the single cert in an array and continue.
Both CA and clone CA installed fine and passed smoke test.
ACK. Just one thing, please add a space after the comma: if not isinstance(certs,types.ListType): -- Endi S. Dewata
Added the space. Pushed to master. --Abhishek On Tue, 2013-04-23 at 20:37 -0500, Endi Sukma Dewata wrote:
On 4/23/2013 5:23 PM, Abhishek Koneru wrote:
Please review the patch with fix for issue #593.
Issue:
The code expects a list of system certs in a configuration result. But if there is only one cert, the JSON result has just the object but not a list with one object.
Fix:
Put the single cert in an array and continue.
Both CA and clone CA installed fine and passed smoke test.
ACK. Just one thing, please add a space after the comma:
if not isinstance(certs,types.ListType):
participants (2)
-
Abhishek Koneru -
Endi Sukma Dewata