[pki-devel][PATCH] 0016-Implement-Symmetric-Key-Changeover-Feature.patch
[PATCH] Implement Symmetric Key Changeover Feature 1. Created code to actually change the key over to a new key set. 2. Made calls to the code from the format and enrollment operations, the Pin Reset processor will do so when completed. 3. Tested with real card. Was able to change to key set #2 and then back to stock Ticket #878.
ACK. However, for next patch: * I think as long as they still apply, you should put the original comments (or the improvement of which) in the same place. For instance, the original putKeys() puts the sample and layout of the key data at top of the function. Your putKyes() has no comments at all. Come to think of it, I might have missed this (lack of comments) in my previous reviews. If you spot them, please put them in the future patchs. Christina On 07/25/2014 11:37 AM, John Magne wrote:
[PATCH] Implement Symmetric Key Changeover Feature
1. Created code to actually change the key over to a new key set. 2. Made calls to the code from the format and enrollment operations, the Pin Reset processor will do so when completed. 3. Tested with real card. Was able to change to key set #2 and then back to stock
Ticket #878.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Based on cfu's ack, pushed to master. Will deal with missing comment blocks conveniently in next submission. ----- Original Message -----
From: "Christina Fu" <cfu@redhat.com> To: pki-devel@redhat.com Sent: Friday, July 25, 2014 6:51:54 PM Subject: Re: [Pki-devel] [pki-devel][PATCH] 0016-Implement-Symmetric-Key-Changeover-Feature.patch
ACK.
However, for next patch: * I think as long as they still apply, you should put the original comments (or the improvement of which) in the same place. For instance, the original putKeys() puts the sample and layout of the key data at top of the function. Your putKyes() has no comments at all. Come to think of it, I might have missed this (lack of comments) in my previous reviews. If you spot them, please put them in the future patchs.
Christina
On 07/25/2014 11:37 AM, John Magne wrote:
[PATCH] Implement Symmetric Key Changeover Feature
1. Created code to actually change the key over to a new key set. 2. Made calls to the code from the format and enrollment operations, the Pin Reset processor will do so when completed. 3. Tested with real card. Was able to change to key set #2 and then back to stock
Ticket #878.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Christina Fu -
John Magne