Dogtag 10 Python Profile Client API documentation for review
Please review the documentation for the ProfileClient on the python side. Link: http://pki.fedoraproject.org/wiki/Dogtag_10_Python_Profile_Client_API --Abhishek
Some basic comments to be begin with: 1. You do not include methods and parameters for ProfileOutputa and ProfilePolicySets. 2. In your initial setup code, you put the auth-cert.pem in /tmp. Its better to put that in the user's home directory. Also, you make a connection to the http port. That cannot be correct because all these calls require client auth. 3. In your code example in creating an profile, you use the add_attribute() method to add attributes to an existing inout. It would also be valuable to add methods to add/remove attributes from ProfileInput. so input = ProfileInput("SubjectNameInput", "com.netscape....") input.add_attribute(ProfileAttribute("sn_e")) ... profile.add_input("id1", input) 4. In fact, I think your example is not correct. There is an id -- like "id1" which is associated with the profile, not the specific input. 5. You need to specify which paramters are optional. Those that are optional should be made keyword params with a default. 6. When deleting a profile, the profile must be disabled first. Ade On Wed, 2014-04-30 at 01:00 -0400, Abhishek Koneru wrote:
Please review the documentation for the ProfileClient on the python side.
Link: http://pki.fedoraproject.org/wiki/Dogtag_10_Python_Profile_Client_API
--Abhishek
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On Mon, May 05, 2014 at 10:13:39AM -0400, Ade Lee wrote:
Some basic comments to be begin with:
1. You do not include methods and parameters for ProfileOutputa and ProfilePolicySets.
2. In your initial setup code, you put the auth-cert.pem in /tmp. Its better to put that in the user's home directory. Also, you make a connection to the http port. That cannot be correct because all these calls require client auth.
3. In your code example in creating an profile, you use the add_attribute() method to add attributes to an existing inout. It would also be valuable to add methods to add/remove attributes from ProfileInput.
so input = ProfileInput("SubjectNameInput", "com.netscape....") input.add_attribute(ProfileAttribute("sn_e")) ... profile.add_input("id1", input)
4. In fact, I think your example is not correct. There is an id -- like "id1" which is associated with the profile, not the specific input.
5. You need to specify which paramters are optional. Those that are optional should be made keyword params with a default.
6. When deleting a profile, the profile must be disabled first.
Ade On Wed, 2014-04-30 at 01:00 -0400, Abhishek Koneru wrote:
Please review the documentation for the ProfileClient on the python side.
Link: http://pki.fedoraproject.org/wiki/Dogtag_10_Python_Profile_Client_API
--Abhishek
Is someone (Abhishek?) already assigned to implement this API once the design is finalised? If not, I'll take it, as I think I'm going to need it for profiles in FreeIPA. Fraser
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On Tue, 2014-05-06 at 10:37 +1000, Fraser Tweedale wrote:
On Mon, May 05, 2014 at 10:13:39AM -0400, Ade Lee wrote:
Some basic comments to be begin with:
1. You do not include methods and parameters for ProfileOutputa and ProfilePolicySets.
2. In your initial setup code, you put the auth-cert.pem in /tmp. Its better to put that in the user's home directory. Also, you make a connection to the http port. That cannot be correct because all these calls require client auth.
3. In your code example in creating an profile, you use the add_attribute() method to add attributes to an existing inout. It would also be valuable to add methods to add/remove attributes from ProfileInput.
so input = ProfileInput("SubjectNameInput", "com.netscape....") input.add_attribute(ProfileAttribute("sn_e")) ... profile.add_input("id1", input)
4. In fact, I think your example is not correct. There is an id -- like "id1" which is associated with the profile, not the specific input.
5. You need to specify which paramters are optional. Those that are optional should be made keyword params with a default.
6. When deleting a profile, the profile must be disabled first.
Ade On Wed, 2014-04-30 at 01:00 -0400, Abhishek Koneru wrote:
Please review the documentation for the ProfileClient on the python side.
Link: http://pki.fedoraproject.org/wiki/Dogtag_10_Python_Profile_Client_API
--Abhishek
Is someone (Abhishek?) already assigned to implement this API once the design is finalised? If not, I'll take it, as I think I'm going to need it for profiles in FreeIPA.
Fraser Yes, Fraser. Once the design is done, i can start implementing it. The design is based on the implementation on the Java side. Btw, are you OK with the methods defined in the design? Do you have any other methods in mind, that you may need for IPA and should be part of ProfileClient?
--Abhishek
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Please review the document as i addressed the below comments. Python profile client API - http://pki.fedoraproject.org/wiki/Dogtag_10_Python_Profile_Client_API. --Abhishek On Mon, 2014-05-05 at 10:13 -0400, Ade Lee wrote:
Some basic comments to be begin with:
1. You do not include methods and parameters for ProfileOutputa and ProfilePolicySets.
Included the classes.
2. In your initial setup code, you put the auth-cert.pem in /tmp. Its better to put that in the user's home directory. Also, you make a connection to the http port. That cannot be correct because all these calls require client auth.
Changed the connections details to use https.
3. In your code example in creating an profile, you use the add_attribute() method to add attributes to an existing inout. It would also be valuable to add methods to add/remove attributes from ProfileInput.
so input = ProfileInput("SubjectNameInput", "com.netscape....") input.add_attribute(ProfileAttribute("sn_e")) ... profile.add_input("id1", input)
Added methods to ProfileInput and ProfileOutput as well.
4. In fact, I think your example is not correct. There is an id -- like "id1" which is associated with the profile, not the specific input.
As discussed with Ade on IRC, the example is correct. The id is associated with the input for a specific profile.
5. You need to specify which paramters are optional. Those that are optional should be made keyword params with a default. Checked all ProfileClient methods for the same. 6. When deleting a profile, the profile must be disabled first.
Added a call to disable_profile.
Ade
participants (3)
-
Abhishek Koneru -
Ade Lee -
Fraser Tweedale