[PATCH] 781 Added instance and subsystem validation for pki-server ca-* commands.
The pki-server ca-* commands have been modified to validate the instance and the CA subsystem before proceeding with the operation. The usage() methods and invocations have been renamed into print_help() for consistency. https://fedorahosted.org/pki/ticket/2364 -- Endi S. Dewata
On Thu, Jun 30, 2016 at 08:38:57PM -0500, Endi Sukma Dewata wrote:
The pki-server ca-* commands have been modified to validate the instance and the CA subsystem before proceeding with the operation.
The usage() methods and invocations have been renamed into print_help() for consistency.
https://fedorahosted.org/pki/ticket/2364
-- Endi S. Dewata
ACK; pushed to master (f8310a4ff306d28cf25ec71693a2e89c5323564d). There are still lots of pki-server commands that fail if invalid subsystem given, e.g.: # pki-server subsystem-cert-find kra <traceback> AttributeError: 'NoneType' object has no attribute 'find_system_certs' But that can be addressed separately in future patch. Thanks, Fraser
Hi Fraser, All, I am working on some of the error messages in pki-* , you can track this under this BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1351295 On 07/01/2016 09:43 AM, Fraser Tweedale wrote:
On Thu, Jun 30, 2016 at 08:38:57PM -0500, Endi Sukma Dewata wrote:
The pki-server ca-* commands have been modified to validate the instance and the CA subsystem before proceeding with the operation.
The usage() methods and invocations have been renamed into print_help() for consistency.
https://fedorahosted.org/pki/ticket/2364
-- Endi S. Dewata
ACK; pushed to master (f8310a4ff306d28cf25ec71693a2e89c5323564d).
There are still lots of pki-server commands that fail if invalid subsystem given, e.g.:
# pki-server subsystem-cert-find kra <traceback> AttributeError: 'NoneType' object has no attribute 'find_system_certs'
But that can be addressed separately in future patch.
Thanks, Fraser
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
-- Thanks, Abhijeet Kasurde IRC: akasurde http://akasurde.github.io
On 6/30/2016 11:13 PM, Fraser Tweedale wrote:
ACK; pushed to master (f8310a4ff306d28cf25ec71693a2e89c5323564d).
There are still lots of pki-server commands that fail if invalid subsystem given, e.g.:
# pki-server subsystem-cert-find kra <traceback> AttributeError: 'NoneType' object has no attribute 'find_system_certs'
But that can be addressed separately in future patch.
Thanks, Fraser
Thanks! I'll be looking at Abhijeet's patches. -- Endi S. Dewata
participants (3)
-
Abhijeet Kasurde -
Endi Sukma Dewata -
Fraser Tweedale