On 12/03/11 18:31, Adam Young wrote:

On 12/02/2011 06:46 PM, Matthew Harmsen wrote:
Revised Bug #.
_______________________________________________
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
I don't know the code well enough to understand why this makes sense.

Is it right to replace \\s+$ everywhere?

Yes.

This is a fix to a corner-case that was discovered during RHCS 8.1 Q/E testing.

The method where this change is implemented is in constructing a multi-line entry
(which contain embedded NEWLINES) as a part of an LDIF record, and is called by
entries that require this type of formatting. This strips all white-space at the end
of the value returned; any white-space at the beginning of each line of a value must
be maintained.

Each final LDIF entry (single as well as multi-line entry) is output as (entry + NEWLINE),
and thus the corner case that exposed this flaw contained an entry that had been
terminated with a NEWLINE causing a blank line to be interjected into the LDIF record.

This fix has been tested by development, and will be further tested by Q/E during
RHCS 8.1 testing.

-- Matt

_______________________________________________
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel