On 01/04/12 20:29, Ade Lee wrote:
Updated patch to clean up correctly on exit().

Ade

On Wed, 2012-01-04 at 22:36 -0500, Ade Lee wrote:
Updated patch to concatenate the first 13 bytes correctly.  Please
review.

Tested using latest NSS and f15 using RA.  Requests now succeed.
Also tested using latest NSS and f16 using IPA install.  IPA install now
successful.

Note:  

The check in the current code is not really valid.  Right now,  it
checks the first 13 bytes - which should contain the following:

HTTP/1.1 200 OK

It then checks if 200 is a substring of the first 13 bytes - and exits
with a failure otherwise.  This isn't the right thing to do.  For one
thing, valid status codes like 201, 202 etc. would result in failure.
This will become a problem when interacting with the new restful
interface which will return codes other than 200 OK.

I will revisit and fix this in a separate bug.

Ade
_______________________________________________
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel

      

_______________________________________________
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
ACK

Please note that check-ins of this patch need to made to multiple "cloned" bugs for other platforms.