From e79d577c02a4054186723e39e2162579fc0dec14 Mon Sep 17 00:00:00 2001 From: "Endi S. Dewata" Date: Wed, 14 Oct 2015 20:24:53 +0200 Subject: [PATCH] Updated TPS UI element IDs. The TPS UI navigation elements have been updated to add the missing names and to use better names. The checkbox IDs in various pages have also been renamed for consistency. The pki-ui.js has been modified to use the checkbox ID of the template row instead of table name to construct the checkbox ID of the actual rows. https://fedorahosted.org/pki/ticket/1622 --- base/server/share/webapps/pki/js/pki-ui.js | 5 ++++- base/tps/shared/webapps/tps/ui/activities.html | 4 ++-- base/tps/shared/webapps/tps/ui/audit.html | 4 ++-- base/tps/shared/webapps/tps/ui/authenticator.html | 4 ++-- base/tps/shared/webapps/tps/ui/authenticators.html | 4 ++-- base/tps/shared/webapps/tps/ui/certs.html | 4 ++-- base/tps/shared/webapps/tps/ui/config.html | 4 ++-- base/tps/shared/webapps/tps/ui/connector.html | 4 ++-- base/tps/shared/webapps/tps/ui/connectors.html | 4 ++-- base/tps/shared/webapps/tps/ui/group.html | 4 ++-- base/tps/shared/webapps/tps/ui/groups.html | 4 ++-- base/tps/shared/webapps/tps/ui/index.html | 18 +++++++++--------- base/tps/shared/webapps/tps/ui/profile-mapping.html | 4 ++-- base/tps/shared/webapps/tps/ui/profile-mappings.html | 4 ++-- base/tps/shared/webapps/tps/ui/profile.html | 4 ++-- base/tps/shared/webapps/tps/ui/profiles.html | 4 ++-- base/tps/shared/webapps/tps/ui/selftests.html | 4 ++-- base/tps/shared/webapps/tps/ui/tokens.html | 4 ++-- base/tps/shared/webapps/tps/ui/users.html | 4 ++-- 19 files changed, 47 insertions(+), 44 deletions(-) diff --git a/base/server/share/webapps/pki/js/pki-ui.js b/base/server/share/webapps/pki/js/pki-ui.js index c1c57793ce4605ced961c8f06453fd89d71a3d51..2fa47ccc48a65ff781c694662734c5ca26d055d6 100644 --- a/base/server/share/webapps/pki/js/pki-ui.js +++ b/base/server/share/webapps/pki/js/pki-ui.js @@ -393,7 +393,10 @@ var TableItem = Backbone.View.extend({ }, render: function() { var self = this; - var prefix = self.table.$el.attr("name") + "_select_"; + + var template = self.table.template; + var templateCheckbox = $("input[type='checkbox']", template); + var prefix = templateCheckbox.attr("id") + "-"; var templateTDs = $("td", self.table.template); $("td", self.$el).each(function(index) { diff --git a/base/tps/shared/webapps/tps/ui/activities.html b/base/tps/shared/webapps/tps/ui/activities.html index 0762401fd01c35169dc77279ab97a7235e6c03c3..32bc35ac776ea912cd191b054f16c54e4f4dcb70 100644 --- a/base/tps/shared/webapps/tps/ui/activities.html +++ b/base/tps/shared/webapps/tps/ui/activities.html @@ -36,7 +36,7 @@ - + Activity ID Token ID User ID @@ -48,7 +48,7 @@ - + ${id} ${tokenID} ${userID} diff --git a/base/tps/shared/webapps/tps/ui/audit.html b/base/tps/shared/webapps/tps/ui/audit.html index 06457de62a6e2b0c5cb2f32faf7b8f55fac45e17..23012f2143f59f2207325acbefe451c791a24199 100644 --- a/base/tps/shared/webapps/tps/ui/audit.html +++ b/base/tps/shared/webapps/tps/ui/audit.html @@ -71,14 +71,14 @@ - + Name Value - + ${id} ${value} diff --git a/base/tps/shared/webapps/tps/ui/authenticator.html b/base/tps/shared/webapps/tps/ui/authenticator.html index 59d3e40b5054fb9c48e3c542c436769b37fdbce3..5a27eb8e001920770f78dc93fbfa832114ef3531 100644 --- a/base/tps/shared/webapps/tps/ui/authenticator.html +++ b/base/tps/shared/webapps/tps/ui/authenticator.html @@ -75,14 +75,14 @@ - + Name Value - + ${id} ${value} diff --git a/base/tps/shared/webapps/tps/ui/authenticators.html b/base/tps/shared/webapps/tps/ui/authenticators.html index f9b0b0a2836d80e3cb41de37cf0dd8298ecc47ce..521e16e0dfd6253665aaec8216ab15f2a0e1e6a3 100644 --- a/base/tps/shared/webapps/tps/ui/authenticators.html +++ b/base/tps/shared/webapps/tps/ui/authenticators.html @@ -37,14 +37,14 @@ - + Source ID Status - + ${id} ${status} diff --git a/base/tps/shared/webapps/tps/ui/certs.html b/base/tps/shared/webapps/tps/ui/certs.html index 52e229f7bac26536076873a83f98ea379b8ac516..7d91162eb93d1680d314e551611b620ba98c3e1d 100644 --- a/base/tps/shared/webapps/tps/ui/certs.html +++ b/base/tps/shared/webapps/tps/ui/certs.html @@ -38,7 +38,7 @@ - + Certificate ID Serial Number Subject @@ -52,7 +52,7 @@ - + ${id} ${serialNumber} ${subject} diff --git a/base/tps/shared/webapps/tps/ui/config.html b/base/tps/shared/webapps/tps/ui/config.html index 567ee9818c53cfdbc3e96cee3a4e03ec43830da9..228ee6e7434a97b41aa102d6e6ec78b0c1a69349 100644 --- a/base/tps/shared/webapps/tps/ui/config.html +++ b/base/tps/shared/webapps/tps/ui/config.html @@ -55,14 +55,14 @@ - + Name Value - + ${id} ${value} diff --git a/base/tps/shared/webapps/tps/ui/connector.html b/base/tps/shared/webapps/tps/ui/connector.html index 1a017df489ba1f3be73f4938e9171aeb77e86d39..a0a8934b8399ffbff4796e04329a375d8e564cf1 100644 --- a/base/tps/shared/webapps/tps/ui/connector.html +++ b/base/tps/shared/webapps/tps/ui/connector.html @@ -75,14 +75,14 @@ - + Name Value - + ${id} ${value} diff --git a/base/tps/shared/webapps/tps/ui/connectors.html b/base/tps/shared/webapps/tps/ui/connectors.html index 4d4d597725db86a601f67680dbc769e3e6c971e2..2517b9e2647663d39f1ac019fdc42d6f91ef1312 100644 --- a/base/tps/shared/webapps/tps/ui/connectors.html +++ b/base/tps/shared/webapps/tps/ui/connectors.html @@ -38,14 +38,14 @@ - + Connector ID Status - + ${id} ${status} diff --git a/base/tps/shared/webapps/tps/ui/group.html b/base/tps/shared/webapps/tps/ui/group.html index df933815f05d77ea4487a6b7e17269561aac0192..0f3d8872be3894c48e6bc90df1a0d55e75733bba 100644 --- a/base/tps/shared/webapps/tps/ui/group.html +++ b/base/tps/shared/webapps/tps/ui/group.html @@ -64,13 +64,13 @@ - + User ID - + ${id} diff --git a/base/tps/shared/webapps/tps/ui/groups.html b/base/tps/shared/webapps/tps/ui/groups.html index 9f4239db8e50d3db9abd4efe61946a501f2896c3..246df1452b592f4398f0b2d5c659c0ae91bfa724 100644 --- a/base/tps/shared/webapps/tps/ui/groups.html +++ b/base/tps/shared/webapps/tps/ui/groups.html @@ -38,14 +38,14 @@ - + Group ID Description - + ${id} ${description} diff --git a/base/tps/shared/webapps/tps/ui/index.html b/base/tps/shared/webapps/tps/ui/index.html index 357ade514c4835cb672a016bff155ead206bf562..4bf0ea94bc1ed268f34e3c3edb847e3eee0802bc 100644 --- a/base/tps/shared/webapps/tps/ui/index.html +++ b/base/tps/shared/webapps/tps/ui/index.html @@ -50,7 +50,7 @@ $(function() { tps.user = data; var roles = tps.user.Roles.Role; - var user = $("#user"); + var user = $("#navigation [name=account] [name=username]"); user.text(data.FullName); var accounts_menu = $("#navigation [name=accounts]"); @@ -383,22 +383,22 @@ $(function() {